[bugfix] Fix squeue backend crash when job is pending#3690
Merged
Conversation
Signed-off-by: Vasileios Karakasis <vkarak@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3690 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 62 62
Lines 13779 13782 +3
=======================================
+ Hits 12663 12667 +4
+ Misses 1116 1115 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3689.
This was a follow up of #3642 and #3663. The problem was that the
slurmandsqueuebackends filled in thepending_reasonsin a different way. Now this is fixed to also accommodate for job arrays as it was in the original design.